-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnirehtet: update cargo.lock to fix build with rust 1.64.0 #117139
Conversation
Formula/gnirehtet.rb
Outdated
# Building the binary with rust 1.64.0 or later results in an error when running `gnirehtet relay`. | ||
# ERROR Main: Execution error: IO error: Address family not supported by protocol family (os error 47) | ||
# Issue ref: https://github.com/Genymobile/gnirehtet/issues/475 | ||
system "rustup-init", "-qy", "--no-modify-path", "--default-toolchain", "1.63.0" | ||
ENV.prepend_path "PATH", HOMEBREW_CACHE/"cargo_cache/bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anyone knows of an upstreamable fix for Rust 1.64.0+, then we can patch it in instead.
For now, went with workaround of downgrading Rust version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version are our bottles built with? Is the error from building with the wrong version of Rust caught by the test?
A mix of versions, e.g.
Yes, test failed in Rust 1.64.0 PR #111434 - https://github.com/Homebrew/homebrew-core/actions/runs/3109704394/jobs/5041504928#step:10:4266 |
Last commit in 2020, lots of open trivial PRs I'd just mark it as an unmaintained project |
Raised an issue in the upstream about the project status, we can revisit maybe couple of months later. |
Upstream has created a PR to update Rust dependencies in Cargo.lock to fix issue. We can try the PR commit instead. |
Agree, let's try the upstream PR patch instead. |
rustup-init
to get Rust 1.63.0 to fix build
🤖 A scheduled task has triggered a merge. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Needs new bottles since Linux is hitting relocation issue:
However, rebottle attempts fails with Rust 1.64.0+ - https://github.com/Homebrew/homebrew-core/actions/runs/3589552605/jobs/6042109311